Sruhvx-jpg commented on PR #3288:
URL: https://github.com/apache/iceberg-rust/pull/3288#issuecomment-6517439863
Pushed a commit addressing the review feedback:
- **Moved shared test utilities to `crates/test_utils/src/storage/`**:
Relocated `StorageHarness` and `endpoint_probe` into
`iceberg_test_utils::storage`, keeping them generic over `&FileIO` without
backend dependencies (@CTTY).
- **Inlined contract test assertions**: Removed `src/file_io.rs` and the
dangling `run_all_file_io_contract_tests` runner, embedding test assertions
directly into the `#[rstest]` cases in `tests/file_io_suite.rs` (@CTTY).
- **Endpoint probe proxy resilience**: Added `.no_proxy()` to the probe
`reqwest::Client::builder()` to prevent proxy false-positives on localhost
endpoints (@laskoviymishka).
- **Cargo.toml hygiene**: Pointed `reqsign-core` to `{ workspace = true,
optional = true }` in `crates/storage/opendal/Cargo.toml`, and scoped `tokio`
test features (`io-util`, `macros`, `net`) to `[dev-dependencies]` in
`crates/storage/common/Cargo.toml` (@laskoviymishka).
- **Error propagation**: Swapped `TempDir::new().unwrap()` calls for `?` in
`tests/resolving_suite.rs` (@laskoviymishka).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
