jopdorp opened a new pull request, #3585:
URL: https://github.com/apache/iceberg-rust/pull/3585
## Which issue does this PR close?
Part of #1607.
## What changes are included in this PR?
Continues #3046 by @hotcache with their commits as they were, merged with
main, plus the remove-only rewrite from hotcache/iceberg-rust#3 that @JanKaul
asked for. Main moved snapshot production into shared helpers in the meantime,
so the merge puts `MergingSnapshotProducer` on those. It keeps its own manifest
filter: a rewrite replaces the manifest that held the deleted file, so one left
with only deleted entries is dropped like Java does. #3046 can be closed in
favour of this one. When squashing please keep:
Co-authored-by: hotcache <[email protected]>
Co-authored-by: Rexwell Minnis <[email protected]>
## Are these changes tested?
The `transaction::rewrite` tests come along from #3046 and
hotcache/iceberg-rust#3 and read the committed manifests back. Full crate
tests, fmt, clippy and the public API check are clean.
## AI Disclosure
The merge with main and the remove-only change were drafted with an AI
coding assistant, then reviewed and run by us. Worth a close look: the move
onto main's snapshot helpers in `merging.rs`, where the removed files now feed
the shared summary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
