dragonknightk commented on code in PR #3569:
URL: https://github.com/apache/iceberg-rust/pull/3569#discussion_r4412505160
##########
crates/storage/opendal/src/s3.rs:
##########
@@ -203,4 +206,53 @@ mod tests {
assert!(parse_with(Some("false")));
assert!(!parse_with(Some("true")));
}
+
+ #[derive(Debug)]
+ struct EmptyCredentialLoader;
Review Comment:
Done — moved `EmptyCredentialLoader` up next to `parse_with` so the helpers
sit together at the top of the module. `cargo fmt --all -- --check` and `cargo
test -p iceberg-storage-opendal --lib s3` both pass, and CI is green ʕ•ᴥ•ʔ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
