Revanth14 commented on code in PR #2356:
URL: https://github.com/apache/iceberg-go/pull/2356#discussion_r4415620023
##########
table/transaction_delete.go:
##########
@@ -691,11 +691,8 @@ func (isNotTrueVisitor) VisitUnbound(pred
iceberg.UnboundPredicate) truthExprs {
negated = iceberg.NewOr(negated, iceberg.IsNaN(pred.Term()))
}
- // Any other predicate is NULL when its term is NULL. Guard In and NotIn
- // too: binding turns a set that ends up with one value into Equal or
- // NotEqual, which are NULL for a NULL term. A scan with a multi-valued
- // NotIn still matches NULL rows, see
- // https://github.com/apache/iceberg-go/issues/2132.
+ // Any other predicate is NULL when its term is NULL, In and NotIn
Review Comment:
Added under "Unreleased compatibility notes" in `website/src/releases.md`:
multi-valued `NotIn` and `NOT(In(...))` no longer match NULL rows, and a
predicate under NOT on a column missing from an older file matches those rows
as a stored NULL would.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
