Revanth14 commented on code in PR #2356:
URL: https://github.com/apache/iceberg-go/pull/2356#discussion_r4415616418
##########
visitors.go:
##########
@@ -679,7 +680,45 @@ func TranslateColumnNamesForScan(expr BooleanExpression,
fileSchema *Schema) (Bo
return nil, nil, err
}
- return res, tr.columns, nil
+ return resolveNullColumns(res, false), tr.columns, nil
+}
+
+// nullColumn stands for a predicate over a column that is null for every row
+// of a file, which is NULL rather than false. resolveNullColumns replaces it
+// before translation returns.
+type nullColumn struct{}
+
+func (nullColumn) String() string { return "NullColumn()" }
+func (nullColumn) Op() Operation { return OpFalse }
Review Comment:
Added to the `nullColumn` doc: it must not escape
`TranslateColumnNamesForScan`, since `Op()` reports `OpFalse`, which is only
right where no NOT applies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
