kevinjqliu opened a new issue, #157: URL: https://github.com/apache/terraform-provider-iceberg/issues/157
`LICENSE-binary` doesn't account for third-party code copied into individual dependency files. go-licenses only reads module-level LICENSE files, so `dev/update_licenses.sh --check` passes anyway. Found while verifying v0.2.0-rc1; all of these also shipped in 0.1.0 and are still on `main`. The source release and `NOTICE-binary` are fine. **Go BSD-3 code with no entry** (the Go license text already ships, so each needs only a line) - `goccy/go-yaml`: `stdlib_quote.go` - `klauspost/cpuid/v2`: `os_linux_arm64.go` - `hashicorp/terraform-svchost`: `label_iter.go` - `aws/aws-sdk-go-v2`: `aws/signer/internal/v4/host.go` - `aws/aws-sdk-go-v2/internal/v4a`: `internal/v4/host.go` - `aws/smithy-go`: `encoding/encoding.go`, `encoding/json/value.go` (`context/suppress_expired.go` is borderline) **MIT copyright notices missing from the zips** - `hashicorp/terraform-plugin-go`: `tftypes/walk.go` (Martin Atkins) - `hashicorp/go-hclog`: `stacktrace.go` (Uber Technologies) - `goccy/go-json`: `internal/encoder/int.go`, `string.go` (Segment.io) **Wrong entries** - `flate, in github.com/andybalholm/brotli`: not linked. - `simplelru/list.go, in github.com/hashicorp/golang-lru/v2`: the file is `internal/list.go`. `check_nested()` matches on `simplelru/`, so it needs updating too. **Tasks** - [ ] Add the missing entries, and ship the three MIT notices in `licenses-binary/`. - [ ] Fix the two wrong entries. - [ ] Make `update_licenses.sh --check` flag file-level copies and hand-written entries that name unlinked files. _Identified with help from an AI agent._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
