adityaksolves commented on PR #18517: URL: https://github.com/apache/iceberg/pull/18517#issuecomment-6462217311
Thanks @pvary @mxm. I rebased on main and pushed the broader fix. - Adopted the tiered approach from pvary/iceberg@f322d30 (cherry-picked, authorship kept). Schemas that reuse a field name now belonging to a different field id are only a fallback, so the current schema wins even when it needs a data conversion. - Added regression tests for cases A, B, C and D from the table above. A, B and C fail without the change, and D (the external type change) still falls back to the old schema. - Ran the whole `org.apache.iceberg.flink.sink.dynamic` test package and `spotlessCheck` locally on Flink 2.3. One open point: @pvary also suggested a user-facing description of how the Dynamic Sink matches records to schemas. Where would you like it, the class Javadoc or the Flink docs page? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
