adityaksolves commented on PR #18517: URL: https://github.com/apache/iceberg/pull/18517#issuecomment-6285257251
Thanks @mxm, done in 9055c8b. I moved `orderSchemas` out of `CacheItem` into a static method on `TableMetadataCache` and call it from `update()`, so `CacheItem` is now a plain holder and no longer takes `currentSchemaId`. I kept it in the cache rather than `TableUpdater` because `TableUpdater` never sees the schema list: it calls `cache.schema(identifier, input)` and the iteration happens inside the cache. Moving the ordering there would mean changing the `update()` signature and its call sites. Happy to do that instead if you prefer. On the "current first" question: I kept it because after a rollback the current schema is not necessarily the one with the highest id, and the ordering test covers that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
