kevinjqliu commented on code in PR #18660:
URL: https://github.com/apache/iceberg/pull/18660#discussion_r4383071132
##########
kafka-connect/build.gradle:
##########
@@ -74,6 +74,10 @@
project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
hive {
extendsFrom runtimeClasspath
}
+ runtimeClasspath {
+ // keep the hive distribution a superset of main by resolving shared
jars to the same versions
+ shouldResolveConsistentlyWith(hive)
+ }
Review Comment:
this + the `kafka-connect/kafka-connect-runtime/main/LICENSE` and
`kafka-connect/kafka-connect-runtime/main/runtime-deps.txt` change is to make
hive = main + more deps
see
https://github.com/apache/iceberg/pull/18660/changes/401b6f0ab41a8f0225c0efb66d7861afc896b03b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
