laskoviymishka commented on issue #2062: URL: https://github.com/apache/iceberg-go/issues/2062#issuecomment-6395537606
@fallintoplace, pulling you in here. Your refactor work covers a good part of this list, and I’m happy to see this moving. Reviews are up on all of your open PRs. Main thing I want to avoid is us doing overlapping moves at the same time. We already have some overlap: my io ctx change in #2067 touches the same area as your hadoop split and io adapter changes. That gets painful pretty quickly. Can we use this issue to coordinate those changes? - before starting a bigger move, claim it here first, especially package moves - if two PRs overlap, agree here which one lands first and rebase the other - every `!` PR adds a bullet under `Unreleased compatibility notes` in `releases.md` We’ve mostly been doing the last one already since #2266. I’m missing a few on my older PRs too and will backfill them. For the remaining work, I’ll take #2067, the inspect package move (#2083), and ctx on the manifest entry points. Would you want to take the registry work end to end for io + KMS, including how catalogs get a registry? Also maybe the catalog constructor cleanup, since you already started touching that around hadoop. The bigger API decisions that need @zeroshade I’ll keep in -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
