binarybrain-009 commented on PR #18591: URL: https://github.com/apache/iceberg/pull/18591#issuecomment-6388730816
@developer-rpai Thanks for the review! All three are in d3cdf43ed: the deferred event is now cleared before listeners are notified, so it goes out at most once; a new test appends and then deletes in one transaction and checks that no events are sent before the commit and both arrive in order after it; and metrics-reporting.md now says that the commit report and snapshot event for changes in a transaction are sent only after `Transaction.commitTransaction()` succeeds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
