developer-rpai commented on PR #18591: URL: https://github.com/apache/iceberg/pull/18591#issuecomment-6369798324
Makes sense to me, firing listeners before the transaction lands was always a bit off. Two small things. deferredEvent never gets cleared after sendDeferredNotifications, so if commitTransaction were ever retried on the same instance the event could go out twice; nulling it after sending seems cheap. And a test with two producers in one transaction (say an append then a delete) checking both events fire in order after commit would cover the loop in BaseTransaction. Worth a line in the docs too since listeners that relied on the per update event inside a transaction will see a change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
