mbutrovich commented on PR #3969: URL: https://github.com/apache/iceberg-python/pull/3969#issuecomment-6367270625
> I think really we want these to come from the validations repo instead so I'll remove them for now and just include unit tests Could the three inline vectors from @kevinjqliu's branch ([`test_stream.py#L40-L60`](https://github.com/kevinjqliu/iceberg-python/blob/82457204eb2d95b8788a5fd6942ab2a908d9c5dd/tests/encryption/test_stream.py#L40-L60)) stay in this PR until #4010 replaces them? They're hex strings in a `.py` file, so no binaries ship in the sdist. At the head commit, the only bytes checked against Java are the 8 byte header. Nothing checks the nonce and tag layout or the AAD prefix concatenation against another implementation's output. I ran Kevin's `test_decrypts_a_java_written_stream` against the head commit and all three cases pass, so it's a copy and paste. #4010 also still describes "the fixtures added in #3969", which are no longer here. Could it point at the commit that generated them (f5baaa55) so the iceberg-verification work starts from the same parameters? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
