mbutrovich commented on PR #3969: URL: https://github.com/apache/iceberg-python/pull/3969#issuecomment-6367293082
> `decrypt_ags1` can potentially help us enforce `file_length` on decrypt (#4011). At the head commit it does. `_decrypt_ags1` raises when `file_length` is `None` and when it differs from `len(data)` ([`stream.py#L83-L87`](https://github.com/apache/iceberg-python/blob/6efeeaedfd5e48776f28f75c62c52394d0254a98/pyiceberg/encryption/stream.py#L83-L87)), and `test_decrypt_requires_file_length` and `test_decrypt_rejects_a_length_other_than_the_trusted_length` cover both. Should the PR description say `Closes #4011`, or does #4011 stay open until the manifest reader calls `_decrypt_ags1`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
