zhjwpku commented on PR #986: URL: https://github.com/apache/iceberg-cpp/pull/986#issuecomment-6356272661
> > Currently our ci is running on Windows 2025 image which uses MSVC 17.14.37710.0: https://github.com/actions/runner-images/blob/main/images/windows/Windows2025-Readme.md#visual-studio-enterprise-2022. I'm just afraid that it will break in the future. Is it possible to let vcpkg use a higher version? > > @wgtmac unfortunately not since vcpkg provides source distributions and has no control over what versions users compile with. I created this PR since the docs listed 17.12 as supported, but if this would cause maintenance problems, I'm happy to abandon in which case maybe the docs should be updated as requiring atleast 17.14. +1 for updating the doc for minimum MSVC version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
