shangxinli commented on code in PR #1052:
URL: https://github.com/apache/iceberg-cpp/pull/1052#discussion_r4350356819
##########
src/iceberg/schema_field.cc:
##########
@@ -243,7 +243,7 @@ bool DefaultEquals(const std::shared_ptr<const Literal>&
lhs,
bool SchemaField::Equals(const SchemaField& other) const {
return field_id_ == other.field_id_ && name_ == other.name_ && *type_ ==
*other.type_ &&
- optional_ == other.optional_ &&
+ optional_ == other.optional_ && doc_ == other.doc_ &&
Review Comment:
nit: doc_ is a plain std::string, so no-doc and doc set to empty compare
equal here, while Java's Objects.equals at Types.java:983 treats null and empty
as different schemas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
