gty404 opened a new pull request, #1052: URL: https://github.com/apache/iceberg-cpp/pull/1052
Changing only a field's documentation through `SetCurrentSchema` silently reuses the previous schema ID and discards the new doc. Include `doc` in `SchemaField` equality so schema deduplication records doc-only changes, including nested fields, while preserving the existing default-value comparisons. Add regressions for required/optional fields, nested struct/list/map fields, doc replacement/addition/removal, metadata JSON round trips, identical-schema deduplication, and historical schema ID reuse. Update two metadata deserialization expectations to include the doc already present in their JSON fixtures. Validation: - The three new regression tests failed before the fix and passed afterward in the original checkout. - Rebuilt and ran `schema_test`, `table_test`, and `json_serde_test` on the PR branch based on current upstream `main`. - Ran `clang-format` and `git diff --check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
