JosephLenton opened a new pull request, #3512:
URL: https://github.com/apache/iceberg-rust/pull/3512

   This adds the ability to set if we are using `aws-lc-rs` or `ring` for TLS.
   
    - Add feature flags `aws-lc-rs` (default) and `ring`.
    - When `ring` is set, the `ring` provider is used over `aws-lc-rs`.
   
   ## Which issue does this PR close?
   
   - Closes #3511
   
   ## What changes are included in this PR?
   
   It adds two feature flags:
    - `aws-lc-rs` (on by default) -- sets dependencies to use the 
[aws-lc-rs](https://crates.io/crates/aws-lc-rs/) crate.
    - `ring` -- sets dependencies to use the 
[ring](https://crates.io/crates/ring) crate.
   
   ## Are these changes tested?
   
   There are no tests. I'm not sure if switching the crypto dependency by a 
flag needs a test. I'm happy to go and build an E2E test if it is needed.
   
   ## AI Disclosure
   
   All of the code was done by Claude. I reviewed it, and tweaked some of the 
comments.
   
   The issue and commit message are both written by a human.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to