zeroshade commented on code in PR #2239:
URL: https://github.com/apache/iceberg-go/pull/2239#discussion_r4329585182
##########
table/transaction.go:
##########
@@ -1732,6 +1745,15 @@ func (t *Transaction) ReplaceDataFilesWithDataFiles(ctx
context.Context, filesTo
return errors.New("cannot delete files that do not belong to
the table")
}
+ // On v3 every removed file takes its deletion vector with it.
+ // DVs only exist from v3, so v2 skips the read.
+ var dvs liveDeletionVectors
+ if meta.formatVersion >= 3 {
Review Comment:
You're right: the early return on an empty `filesToDelete` plus the
`len(markedForDeletion) != len(setToDelete)` check mean it can't be empty
there, so no guard needed. Thanks for clarifying, and for the description
update. That's a more accurate scope for the replay change than my note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
