kinolaev commented on PR #18542: URL: https://github.com/apache/iceberg/pull/18542#issuecomment-6236918487
@developer-rpai, I don't think `fromSchema.findColumnName` can return `null` here. The equality field IDs are either resolved from names passed to `DynamicRecord` or copied from `schema.identifierFieldIds()` (see `DynamicSinkUtil.getEqualityFieldIds`). In both cases, all equality field IDs are guaranteed to exist in the corresponding schema. Could you describe a scenario or code path where drift could actually happen? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
