kinolaev commented on code in PR #18542:
URL: https://github.com/apache/iceberg/pull/18542#discussion_r4311599282
##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java:
##########
@@ -1955,14 +1955,7 @@ private void runTest(
Map<String, String> writeProperties)
throws Exception {
executeDynamicSink(
- dynamicData,
- env,
- immediateUpdate,
- parallelism,
- null,
- false,
- writeProperties,
- TableCreator.DEFAULT);
+ dynamicData, env, immediateUpdate, parallelism, null, false,
writeProperties);
Review Comment:
@mxm, I've reverted the change in 2.3 and brought 1.20 and 2.2 in sync with
it (d733529ce8f864607ed3db042c383d4b3df37d37). The backport is clean now. I'd
still prefer that only the first commit is merged, but keeping both works for
me as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
