JeonDaehong commented on PR #3454: URL: https://github.com/apache/iceberg-rust/pull/3454#issuecomment-6232920352
Thanks @akshat-lakhera for checking this against the roaring source. Addressed in 0bc58a09b: 1. Added `test_ranges_join_runs_across_2_16`, which checks that a run across 2^16 comes back as one range, both when `next_range` picks it up and when the run starts within the positions walked first. I also changed the `ranges()` doc to say a run is split at each 2^32 boundary. 2. The randomized reader test now ends the file at or just after a deleted position half the time, so deletes past the end of the file are covered with the last row group both selected and skipped. 3. Moved the `u64::MAX` note to `ranges()`. 4. Agreed. I'll add the benchmark as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
