kevinjqliu commented on code in PR #3481:
URL: https://github.com/apache/iceberg-rust/pull/3481#discussion_r4297851471
##########
.asf.yaml:
##########
@@ -33,14 +33,23 @@ github:
squash_commit_message: PR_TITLE_AND_COMMIT_DETAILS
merge: false
rebase: false
- protected_branches:
- main:
+ # Disabled: GitHub blocks ruleset bypass while classic protection exists.
+ # The "Default Branch Protection" ruleset replaces it.
+ protected_branches: ~
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ excludes: []
+ bypass_teams:
+ - root
+ restrict_deletion: true
+ restrict_force_push: true
+ required_linear_history: true
required_pull_request_reviews:
required_approving_review_count: 1
- dismiss_stale_reviews: false
-
- required_linear_history: true
Review Comment:
`required_linear_history` is not removed, still set to true in the default
branch ruleset
##########
.asf.yaml:
##########
Review Comment:
added it back, just to be explicit.
`dismiss_stale_reviews: false` is the default setting
##########
.asf.yaml:
##########
Review Comment:
this is a valid asf.yaml syntax
##########
.asf.yaml:
##########
@@ -33,14 +33,24 @@ github:
squash_commit_message: PR_TITLE_AND_COMMIT_DETAILS
merge: false
rebase: false
- protected_branches:
- main:
+ # Disabled: GitHub blocks ruleset bypass while classic protection exists.
+ # The "Default Branch Protection" ruleset replaces it.
+ protected_branches: ~
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ excludes: []
+ bypass_teams:
+ - root
+ restrict_deletion: true
+ restrict_force_push: true
Review Comment:
newly added, to match the existing "classic protection" behavior (what
`protected_branches` sets)
##########
.asf.yaml:
##########
@@ -33,14 +33,23 @@ github:
squash_commit_message: PR_TITLE_AND_COMMIT_DETAILS
merge: false
rebase: false
- protected_branches:
- main:
+ # Disabled: GitHub blocks ruleset bypass while classic protection exists.
+ # The "Default Branch Protection" ruleset replaces it.
+ protected_branches: ~
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
Review Comment:
this refers to the same `main` branch as before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
