wgtmac commented on code in PR #976:
URL: https://github.com/apache/iceberg-cpp/pull/976#discussion_r4278667448
##########
src/iceberg/table_scan.h:
##########
@@ -92,9 +115,22 @@ class ICEBERG_EXPORT FileScanTask : public ScanTask {
int64_t estimated_row_count() const override;
private:
+ // Only set for a partial file; whole-file tasks leave range_ empty.
+ struct Range {
+ int64_t start;
+ int64_t length;
+ // Size when the range was validated. Always positive, so safe to divide
by.
+ int64_t file_size;
Review Comment:
IMHO, this `file_size` field is duplicated with that in the data_file. Can
we remove this to avoid duplication and possible inconsistency in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
