zhjwpku commented on code in PR #976:
URL: https://github.com/apache/iceberg-cpp/pull/976#discussion_r4245939172
##########
src/iceberg/catalog/rest/json_serde.cc:
##########
@@ -110,6 +111,22 @@ constexpr std::string_view kDeleteFileReferences =
"delete-file-references";
constexpr std::string_view kResidualFilter = "residual-filter";
constexpr std::string_view kStart = "start";
constexpr std::string_view kLength = "length";
+constexpr std::string_view kMapKeys = "keys";
+constexpr std::string_view kMapValues = "values";
+
+// Reject values above INT64_MAX; get<int64_t>() would wrap them to negative.
+Result<int64_t> GetRangeValue(const nlohmann::json& json, std::string_view
key) {
Review Comment:
I think we can use the helper functions in `json_util_internal.h`, such as
`IntegerFromJson`. BTW, the function name suggests that it returns a pair
rather than a single value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
