munendrasn commented on code in PR #18462:
URL: https://github.com/apache/iceberg/pull/18462#discussion_r4273972551
##########
gcp/src/integration/java/org/apache/iceberg/gcp/gcs/TestGcsFileIO.java:
##########
@@ -240,6 +241,10 @@ public void readMissingLocation() throws IOException {
}
}
+ @Disabled(
Review Comment:
This failure was discovered while working on #18463 in which some
integration tests were added to observer the `deleteFiles` behavior
One option is to wait enabling any integration test for GCS till the
analytics-core new version is available.
The alternative is to enable integration tests as part of checks and single
tests disabled - This ensures, any future changes in gcsFileIO are tested
through integration tests - I slightly favor this.
Regarding the concern of re-enable test, if it is acceptable, I can create a
github issue and assign to me to enable when new analtycis-core version
available. Please let me know if that works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
