smaheshwar-pltr commented on code in PR #17155:
URL: https://github.com/apache/iceberg/pull/17155#discussion_r4262243658
##########
open-api/rest-catalog-open-api.py:
##########
@@ -791,10 +791,44 @@ class Sha256QueryLocal(Action):
action: Literal['sha-256-query-local']
+class KeyManagementCredential(BaseModel):
+ """
+ Provider-specific credential config for accessing one or more KMS keys
required by an encrypted
+ table operation.
+
+ The key-management provider is advertised in catalog configuration, such
as `encryption.kms-type`
+ returned from `/v1/config`. The `config` map contains provider-specific
properties for the
+ selected key-management provider.
Review Comment:
Hmm but the `/config` endpoint might not know whether the client wants
vended KMS credentials, no? Unless this is suggesting that all clients get the
same value here which seems dubious (also potentially incompatible with
`encryption.kms-impl`).
##########
open-api/rest-catalog-open-api.py:
##########
@@ -791,10 +791,44 @@ class Sha256QueryLocal(Action):
action: Literal['sha-256-query-local']
+class KeyManagementCredential(BaseModel):
+ """
+ Provider-specific credential config for accessing one or more KMS keys
required by an encrypted
+ table operation.
+
+ The key-management provider is advertised in catalog configuration, such
as `encryption.kms-type`
+ returned from `/v1/config`. The `config` map contains provider-specific
properties for the
+ selected key-management provider.
Review Comment:
Hmm but the `/config` endpoint might not know whether the client wants
vended KMS credentials, no? Unless this is suggesting that all clients get the
same value here which seems dubious (also potentially incompatible with
`encryption.kms-impl`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
