xanderbailey commented on code in PR #17155: URL: https://github.com/apache/iceberg/pull/17155#discussion_r4234897843
########## docs/docs/catalog-properties.md: ########## @@ -35,6 +35,7 @@ Iceberg catalogs support using catalog properties to configure catalog behaviors | cache.expiration-interval-ms | 30000 | How long catalog entries are locally cached, in milliseconds; 0 disables caching, negative values disable expiration | | metrics-reporter-impl | org.apache.iceberg.metrics.LoggingMetricsReporter | Custom `MetricsReporter` implementation to use in a catalog. See the [Metrics reporting](metrics-reporting.md) section for additional details | | unique-table-location | false | Whether to use a unique location for new tables | +| encryption.kms-type | null | a predefined KMS client type to use in a catalog for encrypted tables, for example `aws`, `gcp`, or `azure`. See the [Encryption](encryption.md) document for additional details | Review Comment: Does it need to be notes which wins if this is set and a kms-impl is set below? If a custom impl is set so I expect this to be none? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
