openinx commented on code in PR #18439:
URL: https://github.com/apache/iceberg/pull/18439#discussion_r4254720672
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/EqualityConvertPlanner.java:
##########
@@ -82,7 +82,9 @@
* {@link #advancePhase()}.
*
* <p>An {@link EqualityConvertPlan} with the current cycle's metadata is
emitted via the {@link
- * #METADATA_STREAM} side output after the read commands.
+ * #METADATA_STREAM} side output after the read commands. A {@link
EqualityConvertPlan#cycleStart}
+ * marker is emitted first, before any phase watermark, so the committer can
hold back watermarks
+ * until the plan arrives.
Review Comment:
what does you mean `so the committer can hold back watermarks until the plan
arrives.` here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
