pvary commented on code in PR #18439:
URL: https://github.com/apache/iceberg/pull/18439#discussion_r4240527106


##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestEqualityConvertCommitter.java:
##########
@@ -133,6 +133,24 @@ void holdsBackWatermarkUntilCommit() throws Exception {
     }
   }
 
+  @Test
+  void forwardsWatermarkWithoutActiveCycle() throws Exception {

Review Comment:
   We are testing our internal workings, not that the change actually solves 
the original problem of watermarks created by the task is escaping the task 
scope



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to