moomindani commented on PR #3624: URL: https://github.com/apache/iceberg-python/pull/3624#issuecomment-6135138959
@cayetanobv thanks for testing this against the REST fixture, and for tracking down the cause. You're right: `_commit` sets `first_row_id` but never `added_rows`, and `_calculate_added_rows` has no caller. That gap is on main too, not something this branch introduces. This PR covers the manifest writers only; assigning row lineage on commit is #3621, which is still unassigned. A follow-up from you would be very welcome. Would you like to take #3621? Your `add_files` repro would make a good regression test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
