nastra commented on code in PR #18387:
URL: https://github.com/apache/iceberg/pull/18387#discussion_r4247147197


##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/VectorizedSparkOrcReaders.java:
##########
@@ -156,7 +156,9 @@ public Converter primitive(Type.PrimitiveType iPrimitive, 
TypeDescription primit
           break;
         case BINARY:
           primitiveValueReader =
-              Type.TypeID.UUID == iPrimitive.typeId()
+              // iPrimitive is null for the variant metadata and value fields, 
which are

Review Comment:
   I think we can omit this comment here and in the other places as it's AI 
generated and not adding lots of value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to