Revanth14 commented on code in PR #2163:
URL: https://github.com/apache/iceberg-go/pull/2163#discussion_r4238804044
##########
catalog/rest/rest.go:
##########
@@ -1566,7 +1566,7 @@ func (r *Catalog) CreateTable(ctx context.Context,
identifier table.Identifier,
maps.Copy(saved, ret.Config)
scanPlanningConfig := maps.Clone(config)
credsVended := len(ret.StorageCredentials) > 0
- maps.Copy(config, resolveStorageCredentials(ret.StorageCredentials,
ret.MetadataLoc))
+ mergeVendedCredentials(config,
resolveStorageCredentials(ret.StorageCredentials, ret.MetadataLoc))
Review Comment:
Agreed, S3/GCS merging layers onto the base config as on main again, pinned
by `TestTableResponseLayersPartialS3Credential`. I'll take replace vs layer to
a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
