Revanth14 commented on code in PR #2163:
URL: https://github.com/apache/iceberg-go/pull/2163#discussion_r4238802056
##########
catalog/rest/refresh_table_credentials_test.go:
##########
@@ -466,3 +466,63 @@ func TestRefreshTableCredentialsNotFound(t *testing.T) {
assert.Nil(t, refreshed)
assert.ErrorIs(t, err, catalog.ErrNoSuchTable)
}
+
+// TestRefreshTableCredentialsDropsStaleCredentials checks that refreshed
+// credentials replace, rather than sit beside, credentials of the same kind
left
+// in the table's saved config. A stale higher-precedence credential would
+// otherwise shadow the freshly vended one.
+func TestRefreshTableCredentialsDropsStaleCredentials(t *testing.T) {
Review Comment:
Added. Both cases now run through the real Create/Register/Load handlers:
`TestTableResponseVendedADLSTokenClearsShadowingCredentials` covers (a), and
`TestTableResponseLayersPartialS3Credential` covers (b) (the S3 credential
still layers, same as on main).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
