richiebachala commented on PR #2165: URL: https://github.com/apache/iceberg-go/pull/2165#issuecomment-6092688554
Thanks for the thorough review @laskoviymishka. All three points are addressed: - **Hive destination check** (bb63a89): `RenameTable` now checks the destination with a raw `GetTable`, so any table at `to`, Iceberg or not, returns `ErrTableAlreadyExists`; `isNoSuchObjectError` means free, and any other error is returned. - **Rename identity** (bb63a89, 26c1205): the rename test asserts that the table UUID and metadata location survive the rename. - **Unsupported rename** (26c1205): when `SupportsRenameTable` is false, the suite runs `RenameTableNotSupported` instead of skipping, asserting `iceberg.ErrNotImplemented` with the source table left intact. Hadoop's `RenameTable` now wraps that sentinel, and the field doc references #1097. Verified locally: Hadoop and SQL conformance, `go test ./catalog/...`, and REST and Hive conformance against the integration containers all pass. I'll take the follow-ups you suggested as separate PRs: mapping Hive's `AlterTable` `InvalidOperationException` to close the pre-check race, and adding rename to a missing destination namespace and cross-namespace rename conformance tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
