Revanth14 commented on code in PR #2164:
URL: https://github.com/apache/iceberg-go/pull/2164#discussion_r4235528269
##########
table/writer.go:
##########
@@ -239,6 +239,26 @@ type dataFileWriter interface {
writeFile(ctx context.Context, partitionValues map[int]any, task
WriteTask) (iceberg.DataFile, error)
}
+// positionDeleteMetricsProps mirrors Java's MetricsConfig.forPositionDelete:
+// position delete files keep full file_path and pos bounds whatever the table
+// metrics settings are, so readers and conflict checks can resolve the data
+// file a delete file targets from equal file_path bounds.
+var positionDeleteMetricsProps = iceberg.Properties{
+ DefaultWriteMetricsModeKey:
string(tblutils.MetricModeNone),
Review Comment:
The comment now says the `none` default is deliberate and matches Java's
`MetricsConfig.forPositionDelete`, so any column other than `file_path` and
`pos` (such as a future `row`) gets no metrics. It also says the table's
`write.metadata.metrics.*` settings don't apply, and that the shared map must
be treated as read-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
