nastra commented on code in PR #18394:
URL: https://github.com/apache/iceberg/pull/18394#discussion_r4227931262
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -248,6 +254,30 @@ private CloseableIterable<TrackedFile> open() {
return reader;
}
+ private void registerGeospatialFieldStatsBounds(
+ InternalData.ReadBuilder readBuilder, Types.NestedField fieldStats) {
+ Types.NestedField tableField =
tableSchema.findField(StatsUtil.toFieldId(fieldStats.fieldId()));
Review Comment:
I'm not sure we need the table schema for that. The stats schema should
already have that information.
Essentially only GEO lower/upper fields are structs, so I think we could
fetch that info from the Stats schema rather than having to pass table schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
