nastra commented on code in PR #18394:
URL: https://github.com/apache/iceberg/pull/18394#discussion_r4267814943
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -248,6 +254,30 @@ private CloseableIterable<TrackedFile> open() {
return reader;
}
+ private void registerGeospatialFieldStatsBounds(
+ InternalData.ReadBuilder readBuilder, Types.NestedField fieldStats) {
+ Types.NestedField tableField =
tableSchema.findField(StatsUtil.toFieldId(fieldStats.fieldId()));
Review Comment:
I think it is fine to add this logic later once we have any non-geo struct
bounds, but now it seems wasteful to go via the table schema when we can get
the information with the fields that are already present in the manifest
reader. My suggestion would be to remove introducing `tableSchema` into the
manifest reader and rely entirely on the stats schema. We can worry about this
later once it actually becomes an issue, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
