ewoodbury commented on PR #3255: URL: https://github.com/apache/iceberg-rust/pull/3255#issuecomment-6075094793
Thanks for the thorough review @comphead; I applied all three simplifications and the test dedup in ee881aa0f (47 > 40 tests). Good catch on the all-leaves-missing struct. I went ahead and opened up https://github.com/apache/iceberg-rust/issues/3378 and added this under Out of scope. On the optional note, I think it made sense to include reader-level test in `projection.rs` for a separate PR at this point if that works for you, given the testing and cases it now covers here. Agree with this test cleanup though, I think it could live with the #3378 fix as it relates to the end-to-end read behavior. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
