mxm commented on code in PR #18348:
URL: https://github.com/apache/iceberg/pull/18348#discussion_r4217759520
##########
spark/v4.2/spark/src/main/java/org/apache/iceberg/spark/source/SyncSparkMicroBatchPlanner.java:
##########
@@ -118,7 +118,9 @@ public StreamingOffset latestOffset(StreamingOffset
startOffset, ReadLimit limit
return StreamingOffset.START_OFFSET;
}
- if (table().currentSnapshot().timestampMillis() < fromTimestamp) {
+ // Only a new stream starts from the timestamp. A resumed stream continues
from its offset.
+ if (startOffset.equals(StreamingOffset.START_OFFSET)
+ && table().currentSnapshot().timestampMillis() < fromTimestamp) {
Review Comment:
Good idea. I've moved the check into the `START_OFFSET` branch, so
`determineStartingOffset` handles the timestamp. The async planner keeps its
check because it doesn't look up the start in `latestOffset`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
