huaxingao commented on PR #18348: URL: https://github.com/apache/iceberg/pull/18348#issuecomment-6046976343
Thanks @mxm for the PR! Overall LGTM. `docs/docs/spark-configuration.md` describes `stream-from-timestamp` without mentioning restarts. Since this PR changes what happens on restart, maybe add something like: "Only applies when a query starts without a checkpoint; a query restarted from a checkpoint continues from its saved position." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
