findinpath commented on code in PR #18338:
URL: https://github.com/apache/iceberg/pull/18338#discussion_r4211826960
##########
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java:
##########
@@ -87,11 +112,11 @@ private boolean eval(ContentFile<?> file) {
return ROWS_MIGHT_MATCH;
}
- this.valueCounts = file.valueCounts();
- this.nullCounts = file.nullValueCounts();
- this.nanCounts = file.nanValueCounts();
- this.lowerBounds = file.lowerBounds();
- this.upperBounds = file.upperBounds();
+ this.valueCounts = statsForColumns(file, ContentFile::valueCounts);
Review Comment:
> Do we need to do the same with StrictMetricsEvaluator and maybe
V4ManifestReader?
Good catch - applied the fixes and added corresponding test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
