snicholasbarton commented on code in PR #18398:
URL: https://github.com/apache/iceberg/pull/18398#discussion_r4208725752
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetCodecFactory.java:
##########
@@ -58,9 +66,14 @@ protected CompressionCodec getCodec(CompressionCodecName
codecName) {
codecClass = Class.forName(codecClassName);
} catch (ClassNotFoundException e) {
// Try to load the class using the job classloader
- codecClass = configuration.getClassLoader().loadClass(codecClassName);
+ codecClass = new
Configuration(false).getClassLoader().loadClass(codecClassName);
Review Comment:
I think there's actually a more correct thing here which is to reference the
base `CodecFactory` class's `ParquetConfiguration conf` field, so have switched
to that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
