danielcweeks commented on code in PR #18398:
URL: https://github.com/apache/iceberg/pull/18398#discussion_r4198755086
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -186,9 +188,12 @@ public static class WriteBuilder implements
InternalData.WriteBuilder {
private WriteBuilder(OutputFile file) {
this.file = file;
if (file instanceof HadoopOutputFile) {
- this.conf = new Configuration(((HadoopOutputFile) file).getConf());
+ this.conf =
+ new HadoopParquetConfiguration(new
Configuration(((HadoopOutputFile) file).getConf()));
} else {
- this.conf = new Configuration();
+ // A Hadoop Configuration would load core-default.xml from the class
path on first use, a
+ // parse that repeats for every file written. Nothing on this path
needs those defaults.
Review Comment:
These comments now reflect what was removed. They aren't necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
