rdblue commented on code in PR #16936:
URL: https://github.com/apache/iceberg/pull/16936#discussion_r4200274642
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -532,6 +583,13 @@ void manifestFileAdapterDelegation(FileContent
contentType) {
.hasMessage("v4 manifests are not bound to a single partition spec");
}
+ @Test
+ void manifestFileAdapterKeepsZeroFormatVersion() {
+ TrackedFile original = dummyTrackedFile(FileContent.DATA_MANIFEST, 0);
Review Comment:
It is unclear what is being tested here because of the use of
`dummyTrackedFile`. Is this a tracked file? Why would a tracked file have a
format version of 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
