mithun-sudo commented on PR #18330:
URL: https://github.com/apache/iceberg/pull/18330#issuecomment-5998889328

   
   
   
   > What should a user do if they face this new error?
   
   @pvary 
   
   If users hit this error, overwrite and upsert are both enabled, which isn't 
supported. They should pick one:
   
   **Overwrite / reload** — keep `.overwrite(true)`, do not set `upsertMode` / 
equality fields (data files only).
   
   **CDC / upsert** — keep upsert, set `.overwrite(false)` (or omit it; default 
is false) so delete files go through the row-delta path.
   
   ```java
   // Overwrite path: data files only
   DynamicRecord record = new DynamicRecord(...);
   // do not call setUpsertMode / setEqualityFields
   sink.overwrite(true);
   
   // Upsert path: apply deletes via row delta
   record.setUpsertMode(true);
   record.setEqualityFields(Set.of("id"));
   sink.overwrite(false);
   ```
   
   This matches `IcebergCommitter` which already rejects the same combination 
with the same message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to