mithun-sudo opened a new pull request, #18330: URL: https://github.com/apache/iceberg/pull/18330
## Summary - Add the same `Preconditions.checkState` guard in `DynamicCommitter.replacePartitions()` that already exists in `IcebergCommitter` and `IcebergFilesCommitter`. - Add `TestDynamicCommitter.testReplacePartitionsRejectsDeleteFiles` to verify overwrite mode fails when delete files are present. ## Existing state `DynamicCommitter` silently ignored delete files on the replace-partitions path while static sink committers reject that combination. ## Test plan - [x] `./gradlew :iceberg-flink:iceberg-flink-2.3:test --tests "org.apache.iceberg.flink.sink.dynamic.TestDynamicCommitter.testReplacePartitionsRejectsDeleteFiles"` - [x] `./gradlew :iceberg-flink:iceberg-flink-2.3:test --tests "org.apache.iceberg.flink.sink.dynamic.TestDynamicCommitter.testReplacePartitions"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
