Revanth14 opened a new issue, #18351:
URL: https://github.com/apache/iceberg/issues/18351

   ### Feature Request / Improvement
   
   `rest-catalog-open-api.yaml` still lists `TrueExpression` and 
`FalseExpression` (`{"type":"true"}` / `{"type":"false"}`) as deprecated 
alternatives in `Predicate`, after apache/iceberg#17138.
   
   These forms don't match the rest of the project:
   - `format/expressions-spec.md` Appendix B doesn't include them. `PREDICATE` 
allows bare `true`/`false`, and `DEPRECATED_PREDICATE` lists only the 
term-based forms.
   - Java's `ExpressionParser.fromJson` rejects them. `{"type":"true"}` 
resolves to the `TRUE` operation, has no case in the switch, and falls through 
to predicate parsing, which requires `term`.
   
    So the reference implementation (and iceberg-go) rejects a form the OpenAPI 
schema says is valid.
   
   **Proposal:** remove `TrueExpression` and `FalseExpression` from 
`Predicate`, leaving the bare boolean. This makes OpenAPI match the expressions 
spec and the reference implementation.
   
   Happy to open the PR.
   
   ### Query engine
   
   None
   
   ### Willingness to contribute
   
   - [x] I can contribute this improvement/feature independently
   - [ ] I would be willing to contribute this improvement/feature with 
guidance from the Iceberg community
   - [ ] I cannot contribute this improvement/feature at this time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to