rdblue commented on code in PR #16025: URL: https://github.com/apache/iceberg/pull/16025#discussion_r4161546608
########## format/spec.md: ########## @@ -943,7 +1068,7 @@ When adding a new data file, its `first_row_id` field is set to `null` because i When reading, the `first_row_id` is assigned by replacing `null` with the manifest's `first_row_id` plus the sum of `record_count` for all data files that preceded the file in the manifest that also had a null `first_row_id`. -The inherited value of `first_row_id` must be written into data file metadata when creating existing and deleted entries. The value of `first_row_id` for delete files is always `null`. +The inherited value of `first_row_id` must be written into data file metadata when creating existing and deleted entries. In v4, this also applies to MODIFIED and REPLACED entries. The value of `first_row_id` for delete files is always `null`. Review Comment: MODIFIED and REPLACED are only valid in v4, so we don't have to mention v4 here. It can just be: ```suggestion The inherited value of `first_row_id` must be written into data file metadata for all entries with a status other than `ADDED`. The value of `first_row_id` for delete files is always `null`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
