grantatspothero commented on code in PR #18338:
URL: https://github.com/apache/iceberg/pull/18338#discussion_r4159644461
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -413,6 +413,16 @@ private static boolean requireStatsProjection(Expression
rowFilter, Collection<S
&& !columns.containsAll(STATS_COLUMNS);
}
+ private F withFilterableStats(F contentFile) {
+ if (contentFile.content() == FileContent.EQUALITY_DELETES
+ && !contentFile.equalityFieldIds().isEmpty()) {
+ // only equality delete's equality-field stats are relevant for pruning
+ return
contentFile.copyWithStats(Set.copyOf(contentFile.equalityFieldIds()));
Review Comment:
I was surprised equality delete files could contain more columns than just
the equaliy fields, but it is supported per spec:
https://iceberg.apache.org/spec/#equality-delete-files
> Equality delete files identify deleted rows in a collection of data files
by one or more column values, and may optionally contain additional columns of
the deleted row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
